Ecere SDK/eC Forums • View topic - Regression, or me being stupid?




Ecere SDK/eC Forums

Ecere Developers Community

Regression, or me being stupid?

General help: new users, installing the Ecere SDK, using the IDE to compile and run applications.

Regression, or me being stupid?

Postby shakeshuck » Thu Dec 14, 2017 11:36 am

Hi Guys,

It's a while since I last tried ecere; I think the last time was on Windows. I'm now trying to compile ecere 44.15 on OpenSUSE 42.2, but have run into an issue that looks the same as this one:
https://bugs.debian.org/cgi-bin/bugrepo ... bug=808108
(except for reported line numbers)

I have tried to get the dependencies as near as I can guess. Is it possible the error has regressed, is it due to me using a different distro, or simply something I have missed?

Thanks,

Graham.
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm

Re: Regression, or me being stupid?

Postby jerome » Thu Dec 14, 2017 9:15 pm

Hi Graham,

I'm not aware of any such regression or new issue.
Could you paste the exact error you're getting and the version of Giflib that you have installed?

Do you have those full lines in ecere/src/gfx/bitmaps/GIFFormat.ec:

Code: Select all
#if (GIFLIB_MAJOR > 5 || (GIFLIB_MAJOR == 5 && GIFLIB_MINOR >= 1))
      GifFileType * gifFile = DGifOpen(f, ReadData, null);
#else
      GifFileType * gifFile = DGifOpen(f, ReadData);
#endif
 

Try the latest from http://github.com/ecere/ecere-sdk ?

Thanks,

-Jerome
jerome
Site Admin
 
Posts: 623
Joined: Sat Jan 16, 2010 11:16 pm

Re: Regression, or me being stupid?

Postby shakeshuck » Fri Dec 15, 2017 4:52 am

Hi Jerome,

I initially had some extra warnings about the number of parameters, but now it just does:
Code: Select all
graham@linux-flf7:~/Downloads/ecere/ecere-sdk-0.44.15> make
Bootstrapping eC compiling tools...
Building ecere...
Building ec...
Building ecp...
Building ecc...
Building ecs...
All done!
Building 2nd stage ecere...
obj/release.linux/GIFFormat.c: In function ‘__ecereMethod___ecereNameSpace__ecere__gfx__bitmaps__GIFFormat_Load’:
obj/release.linux/GIFFormat.c:1034:1: error: too few arguments to function ‘DGifOpen’
 GifFileType * gifFile = DGifOpen(f, (void *)(__ecereNameSpace__ecere__gfx__bitmaps__ReadData));
 ^
obj/release.linux/GIFFormat.c:573:15: note: declared here
 GifFileType * DGifOpen(void * userPtr, InputFunc readFunc, int * Error);
               ^
Makefile:1610: recipe for target 'obj/release.linux/GIFFormat.o' failed
make[1]: *** [obj/release.linux/GIFFormat.o] Error 1
Makefile:204: recipe for target 'ecere' failed
make: *** [ecere] Error 2


The Giflib-devel version is reported as 5.0.5-11.1, at least according to the package manager; as they say on "Mythbusters": "Thaaar's your problem!". ;)
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm

Re: Regression, or me being stupid?

Postby shakeshuck » Fri Dec 15, 2017 5:16 am

Running make clean first added this warning:

Code: Select all
ecere-sdk-0.44.15/ecere/src/gfx/bitmaps/GIFFormat.ec:34:31: warning: not enough arguments for function DGifOpen (2 given, expected 3)
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm

Re: Regression, or me being stupid?

Postby jerome » Fri Dec 15, 2017 8:33 am

This is strange... apparently the parameter was added all the way back in 5.0.0.

So I really don't know what to make of that commit:

https://github.com/ecere/ecere-sdk/comm ... 4c71d420d4

Seems like it was totally unjustified from looking at the GifLib 5.0.0 source code.
I would suggest to revert that commit, but then I'd swear I had to do this to fix something... Very strange :S

-Jerome
jerome
Site Admin
 
Posts: 623
Joined: Sat Jan 16, 2010 11:16 pm

Re: Regression, or me being stupid?

Postby shakeshuck » Fri Dec 15, 2017 9:17 am

Yup. Been there done that. :roll:

It's only when you take it out and it fails again that you remember why you put it there in the first place...

:oops: :lol:
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm

Re: Regression, or me being stupid?

Postby shakeshuck » Fri Dec 15, 2017 1:14 pm

I think I've got it...

My guess (without checking the other sources) is:
The call to DGifOpen is >= 5
The call to DGifCloseFile is >= 5.1

Cheers,
Graham.
Last edited by shakeshuck on Fri Dec 15, 2017 4:37 pm, edited 1 time in total.
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm

Re: Regression, or me being stupid?

Postby jerome » Fri Dec 15, 2017 3:06 pm

Ahh, that might explain it! Thank you, I will verify that and correct it.
However I imagine most distros have upgraded to 5.1 by now... That came out in 2014 :)
jerome
Site Admin
 
Posts: 623
Joined: Sat Jan 16, 2010 11:16 pm

Re: Regression, or me being stupid?

Postby shakeshuck » Sat Dec 16, 2017 5:38 am

Yes, you have a point. I'm still on Windows 7 as well!
As long as they both send me security patches I don't mind. I know how much 'fun' can be caused by a linux upgrade... ;)
shakeshuck
 
Posts: 42
Joined: Tue Dec 01, 2015 6:52 pm


Return to General Help

Who is online

Users browsing this forum: Google [Bot] and 3 guests

cron